From 360568b96f5805b5a85ea3c9cfa488724bae3144 Mon Sep 17 00:00:00 2001
From: Nicola Zangrandi <wasp@wasp.ovh>
Date: Fri, 21 Feb 2025 08:39:46 +0100
Subject: [PATCH] feat(rules): add rule review process and remove outdated
 process-cleanup

---
 .cursor/rules/conventional_commits.mdc | 35 ++++++++++--
 .cursor/rules/process-cleanup.mdc      | 79 --------------------------
 2 files changed, 30 insertions(+), 84 deletions(-)
 delete mode 100644 .cursor/rules/process-cleanup.mdc

diff --git a/.cursor/rules/conventional_commits.mdc b/.cursor/rules/conventional_commits.mdc
index c06fdd6..d32d82a 100644
--- a/.cursor/rules/conventional_commits.mdc
+++ b/.cursor/rules/conventional_commits.mdc
@@ -5,17 +5,23 @@ globs: **/*
 <rule>
 Before committing changes:
 
-1. Always review changed files:
+1. Review Rules First:
+   - Check if changes affect or require updates to existing rules
+   - Consider if new rules are needed to codify patterns or standards
+   - Update or create rules before committing main changes
+   - Commit rule changes separately from feature changes
+
+2. Review changed files:
    ```bash
    git status  # Check which files were modified
    ```
 
-2. Follow conventional commits format:
+3. Follow conventional commits format:
    ```
    <type>(<scope>): <description>
    ```
 
-3. Types:
+4. Types:
    - feat: A new feature
    - fix: A bug fix
    - docs: Documentation only changes
@@ -25,7 +31,7 @@ Before committing changes:
    - test: Adding missing tests or correcting existing tests
    - chore: Changes to the build process or auxiliary tools
 
-4. Guidelines:
+5. Guidelines:
    - Scope should be derived from the file path or affected component
      - special cases:
        - `notes`, `feeds` and `links` indicate the three subapplication scopes
@@ -36,6 +42,12 @@ Before committing changes:
    - If changes span multiple scopes, use comma separation or omit scope
    - If changes are breaking, add ! after type/scope: feat!: or feat(scope)!:
 
+6. Post-Commit Rule Review:
+   - After each feature or significant change
+   - After each commit that introduces new patterns
+   - When discovering undocumented standards
+   - Before moving to next feature/task
+
 metadata:
   priority: high
   version: 1.0
@@ -54,4 +66,17 @@ examples:
       git status
       CHANGE_DESCRIPTION="fix incorrect date parsing"
       FILE="lib/utils/date.js"
-    output: "fix(lib-utils): fix incorrect date parsing"
\ No newline at end of file
+    output: "fix(lib-utils): fix incorrect date parsing"
+
+  - input: |
+      # After updating build process
+      git status
+      CHANGES="Updated build.sh and added new rule"
+      FILES=".cursor/rules/command-paths.mdc build.sh"
+    output: |
+      # First commit rules
+      git add .cursor/rules/command-paths.mdc
+      git commit -m "feat(rules): add command path resolution standards"
+      # Then commit implementation
+      git add build.sh
+      git commit -m "feat(infra): implement command path resolution"
\ No newline at end of file
diff --git a/.cursor/rules/process-cleanup.mdc b/.cursor/rules/process-cleanup.mdc
deleted file mode 100644
index 09474c1..0000000
--- a/.cursor/rules/process-cleanup.mdc
+++ /dev/null
@@ -1,79 +0,0 @@
----
-description: Guidelines for proper process cleanup in Node/Bun scripts
-globs: **/*.{js,ts}
----
-<rule>
-When managing long-running processes in Node/Bun scripts:
-
-1. Always track processes globally:
-   ```js
-   let currentProcess = null;
-   ```
-
-2. Set up cleanup handlers at the top level:
-   ```js
-   // Basic cleanup
-   process.on('exit', () => {
-     if (currentProcess?.exitCode === null) {
-       currentProcess.kill('SIGTERM');
-     }
-   });
-
-   // Handle interrupts
-   ['SIGINT', 'SIGTERM'].forEach(signal => {
-     process.on(signal, () => {
-       if (currentProcess?.exitCode === null) {
-         currentProcess.kill('SIGTERM');
-       }
-       process.exit();
-     });
-   });
-   ```
-
-3. Always check process state before killing:
-   ```js
-   if (process?.exitCode === null) {
-     process.kill('SIGTERM');
-   }
-   ```
-
-4. Use timeouts for process startup:
-   ```js
-   const startupTimeout = setTimeout(() => {
-     if (process.exitCode === null) {
-       process.kill('SIGTERM');
-     }
-     reject(new Error('Process startup timeout'));
-   }, timeoutMs);
-   ```
-
-5. Clean up in both try/catch and finally blocks:
-   ```js
-   try {
-     // ... process work ...
-   } catch (error) {
-     cleanup();
-     throw error;
-   } finally {
-     cleanup();
-   }
-   ```
-
-metadata:
-  priority: high
-  version: 1.0
-</rule>
-
-examples:
-  - input: |
-      # Starting a server process
-      const server = spawn('server');
-    output: |
-      let currentServer = null;
-      process.on('exit', () => {
-        if (currentServer?.exitCode === null) {
-          currentServer.kill('SIGTERM');
-        }
-      });
-      const server = spawn('server');
-      currentServer = server; 
\ No newline at end of file